Bug 107704

Created attachment 184261 [details] Patch

Comment on attachment 184261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=184261&action=review > Source/WebCore/inspector/front-end/NetworkManager.js:185 > + WebInspector.ConsoleMessage.MessageLevel.Debug, I think that this is still a warning. It should be filtered out by source, not severity. Like I know how console.warn, console.error and console.log are processed. I can stick to some standard in my code and tune my filters accordingly. But I don't know what severity is set for the internal messages. My guess would be that they match the common sense: - warnings warn about errors browser could recover from - errors report problems browser could not recover from - debug generates verbose debugging info flow - I would not expect browser to generate Log level messages to me. I think there should be a set of checkboxes ("Network", "CSS", "JavaScript") in console that would filter by source (in addition to existing message level).

(In reply to comment #2) > > Source/WebCore/inspector/front-end/NetworkManager.js:185 > > + WebInspector.ConsoleMessage.MessageLevel.Debug, > > I think that this is still a warning. It should be filtered out by source, not severity. > ... > - warnings warn about errors browser could recover from > - errors report problems browser could not recover from This makes perfect sense to me. > - debug generates verbose debugging info flow What constitutes "debug" information? Right now, the only message using it is `console.timeEnd`. Not even `console.debug()` outputs at the Debug level (which makes very little sense to me). > - I would not expect browser to generate Log level messages to me. Currently, almost nothing generates Log-level messages: `console.{debug,log,dir,dirxml,clear,trace,startgroup,endgroup,profile,count}` all output at log level, but the only "internal" message at Log level is "XHR finished loading: %s" that users can opt into. > I think there should be a set of checkboxes ("Network", "CSS", "JavaScript") in console that would filter by source (in addition to existing message level). I do think this makes sense, though I'm not at all sure how to present them. :) If that's the right solution, I'd suggest duping this bug against https://bugs.webkit.org/show_bug.cgi?id=98492 and working through UI there.

> > - debug generates verbose debugging info flow > > What constitutes "debug" information? Right now, the only message using it is `console.timeEnd`. Not even `console.debug()` outputs at the Debug level (which makes very little sense to me). I think we should fix console.debug to use proper level. > > - I would not expect browser to generate Log level messages to me. > > Currently, almost nothing generates Log-level messages: `console.{debug,log,dir,dirxml,clear,trace,startgroup,endgroup,profile,count}` all output at log level, but the only "internal" message at Log level is "XHR finished loading: %s" that users can opt into. I am not sure about this one. It looks like a debug level to me. We could tell user to set Network message's level to debug to see that. > > > I think there should be a set of checkboxes ("Network", "CSS", "JavaScript") in console that would filter by source (in addition to existing message level). > > I do think this makes sense, though I'm not at all sure how to present them. :) If that's the right solution, I'd suggest duping this bug against https://bugs.webkit.org/show_bug.cgi?id=98492 and working through UI there. Merging sounds good. I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source).

(In reply to comment #4) > I think we should fix console.debug to use proper level. I'll throw a patch up at https://bugs.webkit.org/show_bug.cgi?id=107816 in a moment. An open question I've asked there: what about `console.info`? Is that TipMessageLevel? Should we have `console.tip`? Should we kill TipMessageLevel entirely, since I have no idea what it means and we're only using it once? :) > > > - I would not expect browser to generate Log level messages to me. > > > > Currently, almost nothing generates Log-level messages: `console.{debug,log,dir,dirxml,clear,trace,startgroup,endgroup,profile,count}` all output at log level, but the only "internal" message at Log level is "XHR finished loading: %s" that users can opt into. > > I am not sure about this one. It looks like a debug level to me. We could tell user to set Network message's level to debug to see that. Yeah, I think it's debug level as well: https://bugs.webkit.org/show_bug.cgi?id=107817 > > I do think this makes sense, though I'm not at all sure how to present them. :) If that's the right solution, I'd suggest duping this bug against https://bugs.webkit.org/show_bug.cgi?id=98492 and working through UI there. > > Merging sounds good. I was thinking of a "Sound Mixer" view where there were vertical severity bars (one per message source). Hrm. That sounds complicated, but we can try it out. I'll merge this bug in and we can fiddle with a solution over there. *** This bug has been marked as a duplicate of bug 98492 ***