Bug 107780

Summary: Split default style-sheet statics out from StyleResolver into its own class
Product: WebKit Reporter: Hayato Ito <hayato>
Component: CSSAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, eric, gyuyoung.kim, macpherson, menard, ojan.autocc, rakuco, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89879, 107777    
Attachments:
Description Flags
Factored default style sheets
none
Patch for landing none

Hayato Ito
Reported 2013-01-23 20:31:31 PST
This will be a separated patch from https://bugs.webkit.org/show_bug.cgi?id=107777.
Attachments
Factored default style sheets (34.81 KB, patch)
2013-02-01 00:16 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (35.00 KB, patch)
2013-02-03 20:01 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2013-02-01 00:16:08 PST
Created attachment 185963 [details] Factored default style sheets
Hayato Ito
Comment 2 2013-02-01 01:00:44 PST
I am wondering whether or not we should add accessors to these static fields to encapsulate those in this case.
Dimitri Glazkov (Google)
Comment 3 2013-02-01 09:07:56 PST
Comment on attachment 185963 [details] Factored default style sheets View in context: https://bugs.webkit.org/attachment.cgi?id=185963&action=review > Source/WebCore/css/CSSDefaultStyleSheets.cpp:30 > +#include "CSSDefaultStyleSheets.h" Should this be called UserAgentStyleSheets?
Hayato Ito
Comment 4 2013-02-03 18:47:06 PST
Thank you for the review. (In reply to comment #3) > (From update of attachment 185963 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185963&action=review > > > Source/WebCore/css/CSSDefaultStyleSheets.cpp:30 > > +#include "CSSDefaultStyleSheets.h" > > Should this be called UserAgentStyleSheets? There is already a file called UserAgentStyleSheets.h. :)
WebKit Review Bot
Comment 5 2013-02-03 18:50:11 PST
Comment on attachment 185963 [details] Factored default style sheets Rejecting attachment 185963 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 185963, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: cpp patching file Source/WebCore/css/CSSDefaultStyleSheets.cpp patching file Source/WebCore/css/CSSDefaultStyleSheets.h patching file Source/WebCore/css/StyleResolver.cpp Hunk #10 succeeded at 5259 (offset 13 lines). Hunk #11 FAILED at 5320. 1 out of 11 hunks FAILED -- saving rejects to file Source/WebCore/css/StyleResolver.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Dimitri Glazkov']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16366026
Hayato Ito
Comment 6 2013-02-03 20:01:59 PST
Created attachment 186289 [details] Patch for landing
WebKit Review Bot
Comment 7 2013-02-03 20:55:14 PST
Comment on attachment 186289 [details] Patch for landing Clearing flags on attachment: 186289 Committed r141733: <http://trac.webkit.org/changeset/141733>
WebKit Review Bot
Comment 8 2013-02-03 20:55:19 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 9 2013-02-03 20:57:29 PST
Yay!
Note You need to log in before you can comment on or make changes to this bug.