Bug 108165

Summary: Revert an accidentally changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: UI EventsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: qinmin, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103747    
Attachments:
Description Flags
Revert the unintentional change.
none
Patch for landing none

Hayato Ito
Reported 2013-01-29 01:02:35 PST
Let me revert one line change in http://trac.webkit.org/changeset/135650. Please see the comment https://bugs.webkit.org/show_bug.cgi?id=103058#c9 for detail. There aren't any layout tests that catch this change. We should add a layout test, but there seems no way to detect the change from LayoutTests. I'll file another bug for that.
Attachments
Revert the unintentional change. (1.32 KB, patch)
2013-01-29 01:14 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.31 KB, patch)
2013-01-29 01:40 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2013-01-29 01:14:25 PST
Created attachment 185194 [details] Revert the unintentional change.
Hayato Ito
Comment 2 2013-01-29 01:23:42 PST
I've filed a bug in https://bugs.webkit.org/show_bug.cgi?id=108167
Hajime Morrita
Comment 3 2013-01-29 01:34:38 PST
Comment on attachment 185194 [details] Revert the unintentional change. View in context: https://bugs.webkit.org/attachment.cgi?id=185194&action=review > Source/WebCore/ChangeLog:3 > + Revert an unintentional changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650. Nit: s/unintentional/unintentionally/ probably can be just said accidentally.
Hayato Ito
Comment 4 2013-01-29 01:39:12 PST
Thank you for the review. Let me land this after updating ChagneLog. (In reply to comment #3) > (From update of attachment 185194 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=185194&action=review > > > Source/WebCore/ChangeLog:3 > > + Revert an unintentional changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650. > > Nit: s/unintentional/unintentionally/ probably can be just said accidentally.
Hayato Ito
Comment 5 2013-01-29 01:40:18 PST
Created attachment 185200 [details] Patch for landing
WebKit Review Bot
Comment 6 2013-01-29 02:16:37 PST
Comment on attachment 185200 [details] Patch for landing Clearing flags on attachment: 185200 Committed r141088: <http://trac.webkit.org/changeset/141088>
WebKit Review Bot
Comment 7 2013-01-29 02:16:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.