Bug 109661

Summary: Implement CoordinatedSurface for Threaded Coordinated Graphics
Product: WebKit Reporter: Jae Hyun Park <jaepark>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, gyuyoung.kim, luiz, noam, rakuco, webkit-ews, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109659, 108899    
Bug Blocks: 102994, 117227    
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch
none
Patch
none
Patch none

Jae Hyun Park
Reported 2013-02-12 21:34:09 PST
To implement Threaded Coordinated Graphics, we need to implement CoordinatedSurface of WebKit1. Currently, Coordinated Graphics is using WebCoordinatedSurface as CoordinatedSurface, which resides in Source/WebKit2. WebCoordinatedSurface is implemented with some WebKit2 specific code, such as CoreIPC. So, we cannot reuse WebCoordinatedSurface in Threaded Coordinated Graphics. Therefore, WebKit1 CoordinatedSurface implementation with similar behavior is needed to implement Threaded Coordinated Graphics.
Attachments
Patch (11.68 KB, patch)
2013-02-12 21:50 PST, Jae Hyun Park 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (12.32 KB, patch)
2013-06-05 03:24 PDT, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (13.49 KB, patch)
2013-07-01 18:31 PDT, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Patch (12.76 KB, patch)
2013-07-01 22:06 PDT, Jae Hyun Park 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jae Hyun Park
Comment 1 2013-02-12 21:50:45 PST
Created attachment 188009 [details] Patch
Jae Hyun Park
Comment 2 2013-02-12 21:52:21 PST
(In reply to comment #1) > Created an attachment (id=188009) [details] > Patch Sorry for the terrible naming. I couldn't come up with anything. Any suggestions on the naming? This patch is the general idea for how WebKit1 CoordinatedSurface would be implemented.
Early Warning System Bot
Comment 3 2013-02-12 21:59:32 PST
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16440635
EFL EWS Bot
Comment 4 2013-02-12 22:00:01 PST
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16439647
Early Warning System Bot
Comment 5 2013-02-12 22:01:33 PST
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16483600
EFL EWS Bot
Comment 6 2013-04-23 21:46:01 PDT
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/219001
Jae Hyun Park
Comment 7 2013-06-05 03:24:49 PDT
Created attachment 203785 [details] Patch Rebased to upstream.
EFL EWS Bot
Comment 8 2013-06-05 04:27:52 PDT
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/701475
Early Warning System Bot
Comment 9 2013-06-05 04:29:40 PDT
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/763265
Early Warning System Bot
Comment 10 2013-06-05 04:31:26 PDT
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/662549
EFL EWS Bot
Comment 11 2013-06-05 04:35:07 PDT
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/769090
Jae Hyun Park
Comment 12 2013-07-01 18:31:08 PDT
Created attachment 205848 [details] Patch
Noam Rosenthal
Comment 13 2013-07-01 21:36:44 PDT
Comment on attachment 205848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205848&action=review > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:58 > + GraphicsContext* context = beginPaint(rect); > + client->paintToSurfaceContext(context); > + endPaint(); It would be better if this was all in one function. Otherwise it may look like beginPaint and endPaint can be called outside the context of paintToSurface. > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:77 > +#if USE(TEXTURE_MAPPER) I think we can remove these in coordinated-graphics code.
Jae Hyun Park
Comment 14 2013-07-01 22:06:20 PDT
Created attachment 205863 [details] Patch
Jae Hyun Park
Comment 15 2013-07-01 22:10:45 PDT
(In reply to comment #13) > (From update of attachment 205848 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205848&action=review > > > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:58 > > + GraphicsContext* context = beginPaint(rect); > > + client->paintToSurfaceContext(context); > > + endPaint(); > > It would be better if this was all in one function. Otherwise it may look like beginPaint and endPaint can be called outside the context of paintToSurface. I agree. Removed beginPaint and endPaint. > > > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:77 > > +#if USE(TEXTURE_MAPPER) > > I think we can remove these in coordinated-graphics code. Fixed. Thanks for the review!
WebKit Commit Bot
Comment 16 2013-07-02 12:17:57 PDT
Comment on attachment 205863 [details] Patch Clearing flags on attachment: 205863 Committed r152307: <http://trac.webkit.org/changeset/152307>
WebKit Commit Bot
Comment 17 2013-07-02 12:18:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.