Bug 118474

Summary: Reduce number of header includes in SVG
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, eflews.bot, fmalita, gyuyoung.kim, krit, laszlo.gombos, pdr, philn, rakuco, rniwa, schenney, webkit-ews, xan.lopez, zimmermann
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107386    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
rwlbuis: review+
Patch for landing none

Chris Dumez
Reported 2013-07-08 09:39:02 PDT
Reduce number of header includes in SVG. In particular, SVGAnimatedPropertyMacros.h no longer brings SVGElement.h header include. This means that the SVGElement class can now have animated properties. This patch is a prerequirement to merge SVGStyledElement into SVGElement. Corresponding blink commit: https://src.chromium.org/viewvc/blink?view=rev&revision=153682
Attachments
Patch (67.76 KB, patch)
2013-07-09 03:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (68.04 KB, patch)
2013-07-09 03:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (68.53 KB, patch)
2013-07-09 03:56 PDT, Chris Dumez 		rwlbuis: review+
DetailsFormatted DiffDiff
Patch for landing (64.34 KB, patch)
2013-07-10 13:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-07-09 03:38:42 PDT
Created attachment 206302 [details] Patch
Chris Dumez
Comment 2 2013-07-09 03:41:31 PDT
Created attachment 206303 [details] Patch
Early Warning System Bot
Comment 3 2013-07-09 03:47:56 PDT
Comment on attachment 206303 [details] Patch Attachment 206303 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/881642
EFL EWS Bot
Comment 4 2013-07-09 03:48:49 PDT
Comment on attachment 206303 [details] Patch Attachment 206303 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1029312
Early Warning System Bot
Comment 5 2013-07-09 03:49:38 PDT
Comment on attachment 206303 [details] Patch Attachment 206303 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1025751
EFL EWS Bot
Comment 6 2013-07-09 03:55:34 PDT
Comment on attachment 206303 [details] Patch Attachment 206303 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/963919
Chris Dumez
Comment 7 2013-07-09 03:56:57 PDT
Created attachment 206304 [details] Patch
Rob Buis
Comment 8 2013-07-10 13:52:11 PDT
Comment on attachment 206304 [details] Patch LGTM.
Chris Dumez
Comment 9 2013-07-10 13:57:34 PDT
Created attachment 206412 [details] Patch for landing
WebKit Commit Bot
Comment 10 2013-07-10 16:49:31 PDT
Comment on attachment 206412 [details] Patch for landing Clearing flags on attachment: 206412 Committed r152553: <http://trac.webkit.org/changeset/152553>
WebKit Commit Bot
Comment 11 2013-07-10 16:49:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.