Bug 135759

Summary: Adjustments to CueBox CSS Width calculations
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, jonlee, mark.lam, philipj, roger_fong, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch eric.carlson: review+

Roger Fong
Reported 2014-08-08 10:58:45 PDT
<rdar://problem/17954473> This is a followup patch to http://trac.webkit.org/changeset/172224 It addresses the bugs I introduced with that revision and fixes the two test failures skipped here: https://bugs.webkit.org/show_bug.cgi?id=135720
Attachments
patch (8.52 KB, patch)
2014-08-08 11:59 PDT, Roger Fong 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2014-08-08 11:59:27 PDT
Created attachment 236293 [details] patch
Eric Carlson
Comment 2 2014-08-08 12:15:32 PDT
Comment on attachment 236293 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236293&action=review r=me with a few nits. Thanks! > Source/WebCore/html/shadow/MediaControlElements.cpp:1243 > + toVTTCue(cue)->shouldChange(); The call to setFontSize should set m_displayTreeShouldChange automatically. > Source/WebCore/html/track/TextTrackCueGeneric.cpp:87 > + setInlineStyleProperty(CSSPropertyWidth, std::min(size * multiplier, 100.0f), CSSPrimitiveValue::CSS_PERCENTAGE); Nit:The "f" isn't necessary, "100.0" should be sufficient. > Source/WebCore/html/track/TextTrackCueGeneric.cpp:89 > + setInlineStyleProperty(CSSPropertyHeight, std::min(size * multiplier, 100.0f), CSSPrimitiveValue::CSS_PERCENTAGE); Ditto. > Source/WebCore/html/track/VTTCue.cpp:176 > + setInlineStyleProperty(CSSPropertyWidth, std::min(static_cast<float>(m_cue.getCSSSize() * multiplier), 100.0f), CSSPrimitiveValue::CSS_PERCENTAGE); Ditto. > Source/WebCore/html/track/VTTCue.cpp:184 > + setInlineStyleProperty(CSSPropertyMaxHeight, 100.0 - position.second, CSSPrimitiveValue::CSS_PERCENTAGE); Ditto.
Roger Fong
Comment 3 2014-08-08 13:11:53 PDT
Landed: http://trac.webkit.org/changeset/172351
Alexey Proskuryakov
Comment 4 2014-08-08 14:42:32 PDT
*** Bug 135720 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.