Bug 143949

Summary: Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the editing and platform directories
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch kling: review+

Darin Adler
Reported 2015-04-20 09:11:38 PDT
Eliminate remaining uses of OwnPtr and PassOwnPtr in WebCore outside the editing and platform directories
Attachments
Patch (48.70 KB, patch)
2015-04-20 09:39 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (49.09 KB, patch)
2015-04-20 10:10 PDT, Darin Adler 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (963.46 KB, application/zip)
2015-04-20 11:20 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (944.66 KB, application/zip)
2015-04-20 11:58 PDT, Build Bot 		no flags
Details
Patch (50.42 KB, patch)
2015-04-22 19:41 PDT, Darin Adler 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2015-04-20 09:39:46 PDT
Created attachment 251161 [details] Patch
Darin Adler
Comment 2 2015-04-20 10:10:45 PDT
Created attachment 251164 [details] Patch
Build Bot
Comment 3 2015-04-20 11:20:31 PDT
Comment on attachment 251164 [details] Patch Attachment 251164 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4713467760082944 Number of test failures exceeded the failure limit.
Build Bot
Comment 4 2015-04-20 11:20:34 PDT
Created attachment 251169 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 5 2015-04-20 11:58:46 PDT
Comment on attachment 251164 [details] Patch Attachment 251164 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4815801999687680 Number of test failures exceeded the failure limit.
Build Bot
Comment 6 2015-04-20 11:58:49 PDT
Created attachment 251180 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Darin Adler
Comment 7 2015-04-22 19:41:14 PDT
Created attachment 251398 [details] Patch
Darin Adler
Comment 8 2015-04-22 19:41:59 PDT
The new patch includes fixes for the test failures.
Andreas Kling
Comment 9 2015-04-22 21:19:47 PDT
Comment on attachment 251398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251398&action=review r=me > Source/WebCore/platform/graphics/FontCascade.cpp:438 > +std::unique_ptr<TextLayout, void (*)(TextLayout*)> FontCascade::createLayout(RenderText&, float, bool) const > { > + return std::unique_ptr<TextLayout, void (*)(TextLayout*)>(nullptr, [](TextLayout*) { }); > } Oh wow, you were not kidding about this monstrosity.
Darin Adler
Comment 10 2015-04-22 22:09:06 PDT
(In reply to comment #9) > Oh wow, you were not kidding about this monstrosity. I found a better way to write this after thinking about some suggestions from Anders. I’ll land it after I double check it compiles.
Darin Adler
Comment 11 2015-04-22 22:21:31 PDT
Committed r183169: <http://trac.webkit.org/changeset/183169>
Note You need to log in before you can comment on or make changes to this bug.