Bug 169912

Summary: [ARM] Add missing MacroAssembler functions after r214187
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam, zherczeg
Priority: P1    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Linux   
Bug Depends on:    
Bug Blocks: 108645, 169820    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2017-03-21 03:54:57 PDT
https://trac.webkit.org/changeset/214187 broke the ARM build because of unimplemented functions: - storeFloat(FPRegisterID src, BaseIndex address) - loadFloat(BaseIndex address, FPRegisterID dest) It's super easy to fix the build, we already have these functions for double type, it's a simple copy/paste patch.
Attachments
Patch (2.12 KB, patch)
2017-03-21 03:58 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2017-03-21 03:58:40 PDT
Created attachment 304998 [details] Patch
Yusuke Suzuki
Comment 2 2017-03-21 04:13:15 PDT
Comment on attachment 304998 [details] Patch r=me
WebKit Commit Bot
Comment 3 2017-03-21 04:42:39 PDT
Comment on attachment 304998 [details] Patch Clearing flags on attachment: 304998 Committed r214220: <http://trac.webkit.org/changeset/214220>
WebKit Commit Bot
Comment 4 2017-03-21 04:42:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.