Bug 199311

Summary:

imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test

Product:

WebKit

Reporter:

Fujii Hironori <fujii>

Component:

Tools / Tests

Assignee:

Fujii Hironori <fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, don.olmstead, ews-watchlist, jhoneycutt, rniwa, ross.kirsling, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
test case comparing "should" and "shoul<span>d</span>"	none
test case	none
test case	none
Archive of layout-test-results from ews101 for mac-highsierra	none
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Archive of layout-test-results from ews116 for mac-highsierra	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
display-inline-style-adjust.html with background:white	none
absolute inline	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
A test case demonstrating position:absolute and position:static can have different dimensions	none
Patch	none
Patch	none

Fujii Hironori

Reported 2019-06-27 21:30:30 PDT

imported/blink/animations/display-inline-style-adjust.html isn't a valid ref test "should" and "shoul<span>d</span>" can end up a different result. This test case is added in this issue. https://bugs.chromium.org/p/chromium/issues/detail?id=389455

Attachments
test case comparing "should" and "shoul<span>d</span>" (1.82 KB, patch) 2019-06-27 21:32 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
test case (1.82 KB, patch) 2019-06-28 00:34 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
test case (2.04 KB, patch) 2019-06-28 04:03 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-highsierra (3.24 MB, application/zip) 2019-06-28 05:10 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.80 MB, application/zip) 2019-06-28 05:17 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews116 for mac-highsierra (3.04 MB, application/zip) 2019-06-28 05:51 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.69 MB, application/zip) 2019-06-28 05:59 PDT, EWS Watchlist	no flags	Details
display-inline-style-adjust.html with background:white (1.27 KB, patch) 2019-07-01 02:02 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
absolute inline (756 bytes, patch) 2019-07-01 02:58 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.62 MB, application/zip) 2019-07-01 04:59 PDT, EWS Watchlist	no flags	Details
A test case demonstrating position:absolute and position:static can have different dimensions (529 bytes, text/html) 2019-07-01 18:07 PDT, Fujii Hironori	no flags	Details
Patch (4.55 KB, patch) 2019-07-01 18:28 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (6.77 KB, patch) 2019-07-02 18:51 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2019-06-27 21:32:25 PDT

Created attachment 373081 [details] test case comparing "should" and "shoul<span>d</span>"

Fujii Hironori

Comment 2 2019-06-28 00:34:52 PDT

Created attachment 373093 [details] test case

Fujii Hironori

Comment 3 2019-06-28 04:03:10 PDT

Created attachment 373103 [details] test case

EWS Watchlist

Comment 4 2019-06-28 05:10:40 PDT

Comment on attachment 373103 [details] test case Attachment 373103 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12602038 New failing tests: imported/blink/animations/display-inline-style-adjust-2.html

EWS Watchlist

Comment 5 2019-06-28 05:10:42 PDT

Created attachment 373106 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 6 2019-06-28 05:17:33 PDT

Comment on attachment 373103 [details] test case Attachment 373103 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12602049 New failing tests: imported/blink/animations/display-inline-style-adjust-2.html

EWS Watchlist

Comment 7 2019-06-28 05:17:35 PDT

Created attachment 373107 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 8 2019-06-28 05:51:27 PDT

Comment on attachment 373103 [details] test case Attachment 373103 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12602075 New failing tests: imported/blink/animations/display-inline-style-adjust-2.html

EWS Watchlist

Comment 9 2019-06-28 05:51:29 PDT

Created attachment 373110 [details] Archive of layout-test-results from ews116 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 10 2019-06-28 05:59:48 PDT

Comment on attachment 373103 [details] test case Attachment 373103 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12602095 New failing tests: imported/blink/animations/display-inline-style-adjust-2.html

EWS Watchlist

Comment 11 2019-06-28 05:59:50 PDT

Created attachment 373111 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Fujii Hironori

Comment 12 2019-07-01 02:02:17 PDT

Created attachment 373215 [details] display-inline-style-adjust.html with background:white legacy-animation-engine/imported/blink/animations/display-inline-style-adjust.html is failing as one pixel image diff on GTK port. The failing reason is the tail of "l" of default 16px font paints on the outside of bounding box. One way to make the test pass for GTK is set background-color white to the subsequent box.

Fujii Hironori

Comment 13 2019-07-01 02:58:24 PDT

Created attachment 373218 [details] absolute inline

EWS Watchlist

Comment 14 2019-07-01 04:59:34 PDT

Comment on attachment 373218 [details] absolute inline Attachment 373218 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12626217 New failing tests: fast/inline/absolute-inline.html

EWS Watchlist

Comment 15 2019-07-01 04:59:36 PDT

Created attachment 373219 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5

Fujii Hironori

Comment 16 2019-07-01 18:07:22 PDT

Created attachment 373293 [details] A test case demonstrating position:absolute and position:static can have different dimensions

Fujii Hironori

Comment 17 2019-07-01 18:28:34 PDT

Created attachment 373296 [details] Patch

Simon Fraser (smfr)

Comment 18 2019-07-02 18:04:02 PDT

Comment on attachment 373296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373296&action=review > LayoutTests/ChangeLog:10 > + created for Blink bug, doesn't seem useful for WebKit. Just skip > + them for all platform. Why not just remove them? I don't think we're bulk-importing blink tests any more.

Fujii Hironori

Comment 19 2019-07-02 18:39:02 PDT

Comment on attachment 373296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373296&action=review >> LayoutTests/ChangeLog:10 >> + them for all platform. > > Why not just remove them? I don't think we're bulk-importing blink tests any more. Got it. Will do so.

Fujii Hironori

Comment 20 2019-07-02 18:51:52 PDT

Created attachment 373375 [details] Patch

Fujii Hironori

Comment 21 2019-07-02 20:42:27 PDT

Comment on attachment 373375 [details] Patch Clearing flags on attachment: 373375 Committed r247086: <https://trac.webkit.org/changeset/247086>

Fujii Hironori

Comment 22 2019-07-02 20:42:36 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 23 2019-07-02 20:43:24 PDT

<rdar://problem/52563701>

Note You need to log in before you can comment on or make changes to this bug.