Bug 202879

Summary: Regression (251018): Wincairo build broken: unresolved external symbol
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, annulen, commit-queue, dino, ews-watchlist, fujii.hironori, graouts, gyuyoung.kim, kbr, kondapallykalyan, lingcherd_ho, rakuco, ryuan.choi, sergio, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=202780
https://bugs.webkit.org/show_bug.cgi?id=202893
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-10-11 23:36:14 PDT
Wincairo build seems to be broken. EWS and build.webkit.org seems to be failing with below build error, e.g.: https://ews-build.webkit.org/#/builders/12/builds/7400/steps/9/logs/stdio, https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Build%29/builds/11035/steps/compile-webkit/logs/stdio [1854/5075] Linking CXX shared library bin64\libGLESv2.dll FAILED: bin64/libGLESv2.dll lib64/libGLESv2.lib cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=Source\ThirdParty\ANGLE\CMakeFiles\GLESv2.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\mt.exe" ... ... ... winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin64\libGLESv2.dll.manifest" failed (exit code 1120) with the following output: Creating library lib64\libGLESv2.lib and object lib64\libGLESv2.exp LINK : warning LNK4217: symbol 'ANGLEGetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ... LINK : warning LNK4217: symbol 'ANGLEResetDisplayPlatform' defined in 'ANGLE.lib(Platform.cpp.obj)' is imported by 'proc_table_egl_autogen.cpp.obj' in function ... ANGLE.lib(Renderer11.cpp.obj) : error LNK2019: unresolved external symbol CreateDXGIFactory1 referenced in function ... bin64\libGLESv2.dll : fatal error LNK1120: 1 unresolved externals [1858/5075] Building CXX object Source\WebCore\PAL\pal\CMakeFiles\PAL.dir\FileSizeFormatter.cpp.obj ninja: build stopped: subcommand failed.
Attachments
Patch (1.15 KB, patch)
2019-10-12 11:09 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 2 2019-10-11 23:38:42 PDT
Seems to be broken by https://trac.webkit.org/changeset/251018/webkit
Stephan Szabo
Comment 3 2019-10-12 11:09:25 PDT
Created attachment 380831 [details] Patch It seems like the function that was being complained about is in dxgi, and adding that to where dxguid is defined seems to work. I'm uncertain if the same issue will apply to FTW as well as the library line there seems similar to the one in PlatformWin.
EWS Watchlist
Comment 4 2019-10-12 11:09:58 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Stephan Szabo
Comment 5 2019-10-12 11:22:28 PDT
I'd gotten a second unrelated error locally after fixing this, but am not sure whether I should be trying to fix that in this or a separate ticket.
WebKit Commit Bot
Comment 6 2019-10-12 22:35:34 PDT
Comment on attachment 380831 [details] Patch Clearing flags on attachment: 380831 Committed r251056: <https://trac.webkit.org/changeset/251056>
WebKit Commit Bot
Comment 7 2019-10-12 22:35:36 PDT
All reviewed patches have been landed. Closing bug.
Aakash Jain
Comment 8 2019-10-13 06:53:27 PDT
It seems like another fix is needed. The build is still failing at a later stage with the error: ..\..\Source\WebCore\platform\network\curl\SynchronousLoaderClientCurl.cpp(32): fatal error C1083: Cannot open include file: 'EventLoop.h': No such file or directory Filed https://bugs.webkit.org/show_bug.cgi?id=202893
Kenneth Russell
Comment 9 2019-10-14 10:30:52 PDT
Sorry about the breakage and thanks for fixing this build issue!
Ling Ho
Comment 10 2019-10-15 15:02:24 PDT
<rdar://problem/56225894>
Note You need to log in before you can comment on or make changes to this bug.