Bug 206629

Summary: media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky timing out
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, eric.carlson, ews-watchlist, glenn, graouts, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jacob Uphoff
Reported 2020-01-22 16:49:41 PST
media/modern-media-controls/media-controller/media-controller-auto-hide.html is flakey timing out as far back as the history goes, so no definitive starting point. This is happening on MacOS Catalina and iOS 13 in wk2. I did not try to reproduce timeout History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-auto-hide.html Diff: --- /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt +++ /Volumes/Data/slave/catalina-debug-tests-wk2/build/layout-test-results/media/modern-media-controls/media-controller/media-controller-auto-hide-actual.txt @@ -1,13 +1,5 @@ -Testing the controls bar fades out as expected after the auto-hide delay expires upon first play. +#PID UNRESPONSIVE - WebKitTestRunner (pid 39281) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS !!shadowRoot.querySelector('.media-controls') became true -PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false -PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true - -PASS successfullyParsed is true - -TEST COMPLETE - +#EOF +#EOF
Attachments
Patch (160.80 KB, patch)
2020-01-26 10:12 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing (146.79 KB, patch)
2020-01-26 11:25 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-22 16:50:14 PST
<rdar://problem/58816827>
Alexey Proskuryakov
Comment 2 2020-01-22 23:07:59 PST
Removing REGRESSIOn from the title, since we don't have the evidence of such. That said, with modern media controls themselves being new, this may be uncovering an actual regression.
Eric Carlson
Comment 3 2020-01-26 10:12:08 PST
Created attachment 388806 [details] Patch
Dean Jackson
Comment 4 2020-01-26 11:06:52 PST
Comment on attachment 388806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388806&action=review > LayoutTests/media/content/test.mp4.js:3 > + return "data:video/mp4;base64," + Not that it matters, but if you used a `` style string you wouldn't need to have all the +es.
Eric Carlson
Comment 5 2020-01-26 11:19:08 PST
(In reply to Dean Jackson from comment #4) > Comment on attachment 388806 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388806&action=review > > > LayoutTests/media/content/test.mp4.js:3 > > + return "data:video/mp4;base64," + > > Not that it matters, but if you used a `` style string you wouldn't need to > have all the +es. Good suggestion, thanks!
Eric Carlson
Comment 6 2020-01-26 11:25:08 PST
Created attachment 388808 [details] Patch for landing
WebKit Commit Bot
Comment 7 2020-01-26 13:10:41 PST
The commit-queue encountered the following flaky tests while processing attachment 388808 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-01-26 13:11:13 PST
Comment on attachment 388808 [details] Patch for landing Clearing flags on attachment: 388808 Committed r255130: <https://trac.webkit.org/changeset/255130>
WebKit Commit Bot
Comment 9 2020-01-26 13:11:14 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 10 2020-01-27 17:46:52 PST
This change seems to have caused media/modern-media-controls/media-controller/media-controller-auto-hide.html to consistently fail an assertion on Mojave debug bots: ASSERTION FAILED: dataRequest.requestedLength >= (dataRequest.currentOffset - dataRequest.requestedOffset) /Volumes/Data/slave/mojave-debug/build/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm(190) : void WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource(WebCore::CachedResource &) 1 0x4e5fd8759 WTFCrash 2 0x4cba1407b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x4d02accac WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource(WebCore::CachedResource&) 4 0x4d02ad5b7 WebCore::WebCoreAVFResourceLoader::notifyFinished(WebCore::CachedResource&) 5 0x4cee821ef WebCore::CachedResource::checkNotify() 6 0x4cee7e071 WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*) 7 0x4cee7f359 WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) 8 0x4cee07501 WebCore::SubresourceLoader::didFinishLoading(WebCore::NetworkLoadMetrics const&)
Ryan Haddad
Comment 11 2020-01-30 19:12:16 PST
(In reply to Ryan Haddad from comment #10) > This change seems to have caused > media/modern-media-controls/media-controller/media-controller-auto-hide.html > to consistently fail an assertion on Mojave debug bots: This was resolved by r255346 or r255347.
Note You need to log in before you can comment on or make changes to this bug.