Bug 218750

Summary: Add infrastructure for WebRTC transforms
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, calvaris, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 218790    
Bug Blocks: 218751    
Attachments:
Description Flags
WIP
ews-feeder: commit-queue-
WIP
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2020-11-10 07:15:20 PST
Add infrastructure for WebRTC transforms
Attachments
WIP (115.24 KB, patch)
2020-11-11 00:23 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
WIP (113.82 KB, patch)
2020-11-11 00:33 PST, youenn fablet 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (117.87 KB, patch)
2020-11-12 11:19 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (117.90 KB, patch)
2020-11-12 11:43 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (117.92 KB, patch)
2020-11-12 12:11 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-11-11 00:23:44 PST
Created attachment 413790 [details] WIP
youenn fablet
Comment 2 2020-11-11 00:33:38 PST
Created attachment 413793 [details] WIP
Eric Carlson
Comment 3 2020-11-12 10:58:38 PST
Comment on attachment 413793 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=413793&action=review > Source/WebCore/Modules/mediastream/RTCRtpReceiverWithTransform.h:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. s/2013/2020/ > Source/WebCore/Modules/mediastream/RTCRtpSenderWithTransform.h:2 > + * Copyright (C) 2013 Apple Inc. All rights reserved. Ditto > Source/WebCore/Modules/mediastream/RTCRtpTransform.cpp:29 > +/* > + * Copyright (C) 2012 Google Inc. All rights reserved. > + * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies). > + * Copyright (C) 2017 Apple Inc. All rights reserved. > + * Is this necessary?
youenn fablet
Comment 4 2020-11-12 11:19:06 PST
Created attachment 413955 [details] Patch
Radar WebKit Bug Importer
Comment 5 2020-11-12 11:34:29 PST
<rdar://problem/71335495>
youenn fablet
Comment 6 2020-11-12 11:43:34 PST
Created attachment 413959 [details] Patch
youenn fablet
Comment 7 2020-11-12 12:11:19 PST
Created attachment 413963 [details] Patch
youenn fablet
Comment 8 2020-11-12 12:22:17 PST
(In reply to Eric Carlson from comment #3) > Comment on attachment 413793 [details] > WIP > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413793&action=review > > > Source/WebCore/Modules/mediastream/RTCRtpReceiverWithTransform.h:2 > > + * Copyright (C) 2013 Apple Inc. All rights reserved. > > s/2013/2020/ > > > Source/WebCore/Modules/mediastream/RTCRtpSenderWithTransform.h:2 > > + * Copyright (C) 2013 Apple Inc. All rights reserved. > > Ditto > > > Source/WebCore/Modules/mediastream/RTCRtpTransform.cpp:29 > > +/* > > + * Copyright (C) 2012 Google Inc. All rights reserved. > > + * Copyright (C) 2013 Nokia Corporation and/or its subsidiary(-ies). > > + * Copyright (C) 2017 Apple Inc. All rights reserved. > > + * > > Is this necessary? Nope! Fixed now.
EWS
Comment 9 2020-11-12 23:20:45 PST
Committed r269764: <https://trac.webkit.org/changeset/269764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413963 [details].
Note You need to log in before you can comment on or make changes to this bug.