Bug 33715

Summary:

[Qt] Add setSpatialNavigationEnabled method to DRT

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Tools / Tests

Assignee:

Antonio Gomes <tonikitoo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, hausmann, jchaffraix, kenneth, webkit.review.bot

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

18662, 33714

Bug Blocks:

Attachments:

Description	Flags
(landed in r55580) patch 0.1	none

Antonio Gomes

Reported 2010-01-15 05:39:30 PST

DRT needs a way to toggle "Spatial Navigation" on and off. This bug is about implementing it to Qt's DRT. SNav itself is being implemented in bug 18662.

Attachments
(landed in r55580) patch 0.1 (4.50 KB, patch) 2010-01-15 05:42 PST, Antonio Gomes	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antonio Gomes

Comment 1 2010-01-15 05:42:39 PST

Created attachment 46675 [details] (landed in r55580) patch 0.1

WebKit Review Bot

Comment 2 2010-01-15 05:47:49 PST

Attachment 46675 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/174029

Antonio Gomes

Comment 3 2010-01-15 05:51:33 PST

(In reply to comment #2) > Attachment 46675 [details] did not build on qt: > Build output: http://webkit-commit-queue.appspot.com/results/174029 I will ignore the build error for now, because this patch depends on patch in but 33714, that on its turn depends on a patch in bug 18662. dep chain is deep and bot build error here is expected :)

Simon Hausmann

Comment 4 2010-01-16 00:59:40 PST

Comment on attachment 46675 [details] (landed in r55580) patch 0.1 r=me

Eric Seidel (no email)

Comment 5 2010-02-02 14:17:44 PST

Ping? This was r+'d two weeks ago.

Antonio Gomes

Comment 6 2010-02-02 17:22:30 PST

(In reply to comment #5) > Ping? This was r+'d two weeks ago. as if https://bugs.webkit.org/show_bug.cgi?id=33714#c11 , this patch can not land before bug 18662 ... which i believe is in a good shape (or close to it)

Antonio Gomes

Comment 7 2010-02-09 06:45:36 PST

Comment on attachment 46675 [details] (landed in r55580) patch 0.1 Clearing r+/cq- since this patch depends on another bug to be landed first.

Antonio Gomes

Comment 8 2010-03-05 08:35:51 PST

landed in r55580

Note You need to log in before you can comment on or make changes to this bug.