Bug 36751

Summary: [Qt] Windows CE build is broken
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: CLOSED FIXED    
Severity: Blocker CC: commit-queue, ismail, jturcotte, laszlo.gombos
Priority: P1 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Patch
none
Patch v2 none

Simon Hausmann
Reported 2010-03-29 03:31:25 PDT
From https://bugs.webkit.org/show_bug.cgi?id=36590#c5 : pcre_compile.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_exec.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_tables.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_ucp_searchfuncs.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory pcre_xclass.cpp c:\qt\wince5\webkit\javascriptcore\wtf\unicode\qt4/UnicodeQt4.h(31) : fatal error C1083: Cannot open include file: 'stdint.h' : No such file or directory JavaScriptCore/os-win32 is missing from the include paths.
Attachments
Patch (2.35 KB, patch)
2010-03-29 03:39 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.09 KB, patch)
2010-04-15 11:15 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2010-03-29 03:39:27 PDT
Created attachment 51896 [details] Patch
Ismail Donmez
Comment 2 2010-03-29 03:41:30 PDT
(In reply to comment #1) > Created an attachment (id=51896) [details] > Patch + +# DEFINES += ENABLE_SVG=0 ENABLE_XPATH=0 ENABLE_XBL=0 \ +# ENABLE_SVG_ANIMATION=0 ENABLE_SVG_USE=0 \ +# ENABLE_SVG_FOREIGN_OBJECT=0 ENABLE_SVG_AS_IMAGE=0 those seems unrelated.
Ismail Donmez
Comment 3 2010-03-30 07:57:47 PDT
Patch fixes the compilation error for me, thanks.
Eric Seidel (no email)
Comment 4 2010-04-01 15:59:34 PDT
Comment on attachment 51896 [details] Patch Can we remove the: # DEFINES += ENABLE_SVG=0 ENABLE_XPATH=0 ENABLE_XBL=0 \ 59 # ENABLE_SVG_ANIMATION=0 ENABLE_SVG_USE=0 \ 60 # ENABLE_SVG_FOREIGN_OBJECT=0 ENABLE_SVG_AS_IMAGE=0 The commented out code seems usless.
Jocelyn Turcotte
Comment 5 2010-04-15 11:15:33 PDT
Created attachment 53454 [details] Patch v2 Upstreaming the patch currently in qt/src/3rdparty/webkit The same as the previous patch except the commented part has been removed
Simon Hausmann
Comment 6 2010-04-16 16:07:41 PDT
I can't really review a patch with my own name in it, but it looks good to me ;)
Eric Seidel (no email)
Comment 7 2010-04-18 16:27:27 PDT
Comment on attachment 51896 [details] Patch Cleared Eric Seidel's review+ from obsolete attachment 51896 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Laszlo Gombos
Comment 8 2010-04-18 21:13:25 PDT
Comment on attachment 53454 [details] Patch v2 lgtm as well, r+.
WebKit Commit Bot
Comment 9 2010-04-18 21:22:53 PDT
Comment on attachment 53454 [details] Patch v2 Clearing flags on attachment: 53454 Committed r57802: <http://trac.webkit.org/changeset/57802>
WebKit Commit Bot
Comment 10 2010-04-18 21:22:58 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 11 2010-04-20 12:02:34 PDT
Revision r57802 cherry-picked into qtwebkit-2.0 with commit 2ccb40583521dc3a8744555663359671a28aaa2a
Note You need to log in before you can comment on or make changes to this bug.