Bug 38685

Summary:

[Qt] tst_QWebPage::inputMethods failing on Maemo5

Product:

WebKit

Reporter:

Diego Gonzalez <diegohcg>

Component:

WebKit Qt

Assignee:

Diego Gonzalez <diegohcg>

Status:

CLOSED FIXED

Severity:

Normal

CC:

hausmann, joseph.ligman, kenneth, laszlo.gombos

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Bug Depends on:

Bug Blocks:

38654

Attachments:

Description	Flags
Patch	kenneth: review-
Patch	hausmann: review-
Patch	kenneth: review-
Patch	kenneth: review+, kenneth: commit-queue-
Patch OK	diegohcg: commit-queue-

Diego Gonzalez

Reported 2010-05-06 13:34:30 PDT

Test failing in Maemo 5 with Qt4.6 FAIL! : tst_QWebPage::inputMethods(QWebView) '!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel)' returned FALSE. () Loc: [/home/diegohcg/webkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1370)] FAIL! : tst_QWebPage::inputMethods(QGraphicsWebView) '!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel)' returned FALSE. () Loc: [/home/diegohcg/webkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1370)]

Attachments
Patch (1.66 KB, patch) 2010-05-07 15:15 PDT, Diego Gonzalez	kenneth: review-	Details Formatted Diff Diff
Patch (2.21 KB, patch) 2010-05-07 15:35 PDT, Diego Gonzalez	hausmann: review-	Details Formatted Diff Diff
Patch (2.87 KB, patch) 2010-05-11 12:23 PDT, Diego Gonzalez	kenneth: review-	Details Formatted Diff Diff
Patch (3.25 KB, patch) 2010-05-11 12:49 PDT, Diego Gonzalez	kenneth: review+ kenneth: commit-queue-	Details Formatted Diff Diff
Patch OK (3.28 KB, patch) 2010-05-11 14:27 PDT, Diego Gonzalez	diegohcg: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Diego Gonzalez

Comment 1 2010-05-07 15:12:23 PDT

The test checks if there is no RequestSoftwareInputPanel event in the EventSpy, when the input form receives a mouse click. QVERIFY(!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel)); As the RequestSoftwareInputPanel should invoke a panel like a virtual keyboard, in Maemo it seems be called as it is a mobile platform. So, for the Maemo's case, the behavior of this the should be changed the the opposite. QVERIFY(viewEventSpy.contains(QEvent::RequestSoftwareInputPanel)); Maybe this test should also fail in another mobile platform like s60, but I didn't test it.

Diego Gonzalez

Comment 2 2010-05-07 15:15:10 PDT

Created attachment 55422 [details] Patch

Kenneth Rohde Christiansen

Comment 3 2010-05-07 15:16:28 PDT

Laszlo, can you verify?

Kenneth Rohde Christiansen

Comment 4 2010-05-07 15:17:27 PDT

Comment on attachment 55422 [details] Patch WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1368 + #ifndef Q_WS_MAEMO_5 It would really be good with a comment here why there are different results, r- because of that. That should ALSO be in the ChangeLog.

Diego Gonzalez

Comment 5 2010-05-07 15:35:31 PDT

Created attachment 55423 [details] Patch Added comments

Simon Hausmann

Comment 6 2010-05-07 15:51:49 PDT

Comment on attachment 55423 [details] Patch So this part of the test checks that the SIP is triggered not on the first mouse click but on the _second_, corresponding to style->styleHint(...::RequestSoftwareInputPanel) != RSIP_OnMouseClick. See QWebPagePrivate::handleSoftwareInputPanel So the auto-test should probably adjust its expected result - either RSIP on first or second click - depending on the return value of the styleHint() function on the current style. Then the auto-test could be written without platform #ifdefs :)

Diego Gonzalez

Comment 7 2010-05-10 09:17:10 PDT

(In reply to comment #6) > (From update of attachment 55423 [details]) > So this part of the test checks that the SIP is triggered not on the first mouse click but on the _second_, corresponding to style->styleHint(...::RequestSoftwareInputPanel) != RSIP_OnMouseClick. > > See QWebPagePrivate::handleSoftwareInputPanel > > So the auto-test should probably adjust its expected result - either RSIP on first or second click - depending on the return value of the styleHint() function on the current style. > > Then the auto-test could be written without platform #ifdefs :) Yeah sure, it's make more sense. Thanks :)

Diego Gonzalez

Comment 8 2010-05-11 12:23:06 PDT

Created attachment 55735 [details] Patch Check if SIP is triggered via styleHint

Kenneth Rohde Christiansen

Comment 9 2010-05-11 12:29:57 PDT

Comment on attachment 55735 [details] Patch WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1371 + int inputPanel= 0; wrong coding style WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1383 + QVERIFY(!viewEventSpy.contains(QEvent::RequestSoftwareInputPanel)); As said earlier, can be please add a comment here explaining the difference

Diego Gonzalez

Comment 10 2010-05-11 12:49:54 PDT

Created attachment 55739 [details] Patch added more comments

Kenneth Rohde Christiansen

Comment 11 2010-05-11 13:01:32 PDT

Comment on attachment 55739 [details] Patch WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1384 + // part of the test can verified as the checks bellow. below WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1381 + // because there is no SIP (Software Input Panel) triggered. In case of mobile In the case of a mobile platform, AN input panel WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:1382 + // platforms a input panel, e.g. virtual keyboard, is normally invoked and the usually might be better than normally WebKit/qt/ChangeLog:10 + Check if the SIP (Software Input Panel) is triggered, + which normally happens on mobile platforms, when a user input form receives + a mouse click. Strange word wrap

Diego Gonzalez

Comment 12 2010-05-11 14:27:47 PDT

Created attachment 55756 [details] Patch OK Adjust comments in the already r+ patch

Diego Gonzalez

Comment 13 2010-05-13 12:38:12 PDT

Landed manually at r59380.

Simon Hausmann

Comment 14 2010-05-13 15:06:48 PDT

<cherry-pick-for-backport: r59380>

Simon Hausmann

Comment 15 2010-05-14 01:06:36 PDT

Revision r59380 cherry-picked into qtwebkit-2.0 with commit f5e95b4fdb7411ca7fbdb7ac1552acd47741e100

Note You need to log in before you can comment on or make changes to this bug.