Bug 45331

Summary: [Qt] Calling Path::closeSubpath() when the path only contains only one line or curve element does not result in the path being closed
Product: WebKit Reporter: Jan Erik Hanssen <jhanssen>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, commit-queue, kling
Priority: P2 Keywords: HTML5, Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
kling: review-
Proposed patch v2 none

Jan Erik Hanssen
Reported 2010-09-07 15:49:55 PDT
Creating an SVG path such as 'M10,10 L100,100 Z' in QtWebKit does not result in the path being closed. The path will be identical to 'M10,10 L100,100' which is not correct.
Attachments
Proposed patch (5.55 KB, patch)
2010-09-07 16:03 PDT, Jan Erik Hanssen 		kling: review-
DetailsFormatted DiffDiff
Proposed patch v2 (6.49 KB, patch)
2010-09-07 18:24 PDT, Jan Erik Hanssen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Erik Hanssen
Comment 1 2010-09-07 16:03:08 PDT
Created attachment 66782 [details] Proposed patch
Andreas Kling
Comment 2 2010-09-07 16:41:21 PDT
Comment on attachment 66782 [details] Proposed patch > +#if PLATFORM(QT) > + m_path.closeCanvasSubpath(); > +#else > m_path.closeSubpath(); > +#endif It's rather un-obvious why we're doing something differently on Qt here. I think all platforms should have closeCanvasSubpath() and we'd call that from here instead. For non-Qt ports, it could be an inline call to closeSubpath() in Path.h
Jan Erik Hanssen
Comment 3 2010-09-07 18:24:49 PDT
Created attachment 66818 [details] Proposed patch v2
Andreas Kling
Comment 4 2010-09-07 18:29:46 PDT
Comment on attachment 66818 [details] Proposed patch v2 r=me
WebKit Commit Bot
Comment 5 2010-09-07 21:03:23 PDT
Comment on attachment 66818 [details] Proposed patch v2 Clearing flags on attachment: 66818 Committed r66948: <http://trac.webkit.org/changeset/66948>
WebKit Commit Bot
Comment 6 2010-09-07 21:03:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.