Bug 54554

Summary: REGRESSION(r78678): Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: bbudge, levin, mnaganov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 54489    
Attachments:
Description Flags
ROLLOUT of r78678 none

WebKit Review Bot
Reported 2011-02-16 07:15:40 PST
http://trac.webkit.org/changeset/78678 broke the build: Breaks NaCl tests in Chromium (Requested by mnaganov on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r78678 (4.75 KB, patch)
2011-02-16 07:16 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-02-16 07:16:07 PST
Created attachment 82629 [details] ROLLOUT of r78678 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
Mikhail Naganov
Comment 2 2011-02-16 07:21:01 PST
Manually committed http://trac.webkit.org/changeset/78705
Mikhail Naganov
Comment 3 2011-02-18 02:02:03 PST
Ah, I'm sorry for not providing you this info at the first hand. Two tests were failing (crashing): - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change.
David Levin
Comment 4 2011-02-18 05:40:24 PST
Comment on attachment 82629 [details] ROLLOUT of r78678 Cleared cq? as this was already landed.
Bill Budge
Comment 5 2011-02-18 14:04:58 PST
Mikhail, I am trying to set breakpoints on the changed code to see why this simple change causes a crash. They never get hit, so I suspect I'm not attached to the right process. Are there any tips you can give me for how to attach (in Visual Studio right now) after the process is created but before too much code gets run? (In reply to comment #3) > Ah, I'm sorry for not providing you this info at the first hand. > Two tests were failing (crashing): > - NaClUITest.PPAPIHelloWorld from nacl_ui_test.cc > - NaClSandboxTest.NaClOuterSBTest from nacl_sandbox_test.cc > > And this was easily reproducible on my Linux machine -- I was able to bisect the roll to find out that this was because of your change.
Mikhail Naganov
Comment 6 2011-02-21 02:09:02 PST
Hi Bill, Take a look at this page: http://dev.chromium.org/developers/how-tos/debugging I used '--renderer-startup-dialog --no-sandbox' flags to get renderer process to stop and show me its PID before it does anything important. You might need to modify the code that starts Chromium from the test.
Note You need to log in before you can comment on or make changes to this bug.