Bug 58703

Summary: Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: FramesAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Minor CC: buildbot, commit-queue, dglazkov, dominicc, jchaffraix, morrita, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 52788    
Bug Blocks: 59802    
Attachments:
Description Flags
Patch
none
Patch none

Roland Steiner
Reported 2011-04-15 15:27:27 PDT
Both functions currently return a ContainerNode*.
Attachments
Patch (14.56 KB, patch)
2011-05-02 11:47 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Patch (15.82 KB, patch)
2011-05-02 14:37 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-05-02 11:47:51 PDT
Created attachment 91948 [details] Patch
Early Warning System Bot
Comment 2 2011-05-02 12:00:24 PDT
Attachment 91948 [details] did not build on qt: Build output: http://queues.webkit.org/results/8532285
Build Bot
Comment 3 2011-05-02 13:19:29 PDT
Attachment 91948 [details] did not build on win: Build output: http://queues.webkit.org/results/8532302
WebKit Review Bot
Comment 4 2011-05-02 14:20:00 PDT
Attachment 91948 [details] did not build on mac: Build output: http://queues.webkit.org/results/8529798
Dimitri Glazkov (Google)
Comment 5 2011-05-02 14:25:35 PDT
Comment on attachment 91948 [details] Patch I am impressed, but the bots aren't! :)
Julien Chaffraix
Comment 6 2011-05-02 14:29:25 PDT
(In reply to comment #5) > (From update of attachment 91948 [details]) > I am impressed, but the bots aren't! :) I missed the WebKit2 directory (class InjectedBundleNodeHandle) which is making the bots sad. Patch forthcoming with this change!
Julien Chaffraix
Comment 7 2011-05-02 14:37:04 PDT
Created attachment 91983 [details] Patch
WebKit Review Bot
Comment 8 2011-05-02 15:45:31 PDT
Attachment 91948 [details] did not build on mac: Build output: http://queues.webkit.org/results/8536049
WebKit Commit Bot
Comment 9 2011-05-03 13:05:32 PDT
The commit-queue encountered the following flaky tests while processing attachment 91983 [details]: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2011-05-03 13:08:36 PDT
Comment on attachment 91983 [details] Patch Clearing flags on attachment: 91983 Committed r85644: <http://trac.webkit.org/changeset/85644>
WebKit Commit Bot
Comment 11 2011-05-03 13:08:42 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 12 2011-05-03 15:10:05 PDT
The commit-queue encountered the following flaky tests while processing attachment 91983 [details]: http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.