Bug 70186

Summary: Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: JavaScriptCoreAssignee: Dmitry Lomov <dslomov>
Status: RESOLVED FIXED    
Severity: Normal CC: dslomov, levin, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65209    
Attachments:
Description Flags
Fix none

Dmitry Lomov
Reported 2011-10-15 16:17:32 PDT
SerializedScriptValue needs to know the message ports being sent with the message to implement trasfer
Attachments
Fix (16.74 KB, patch)
2011-10-15 16:20 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-10-15 16:20:15 PDT
Created attachment 111154 [details] Fix
David Levin
Comment 2 2011-10-15 19:27:47 PDT
At first glance this seems fine. I'll look more and see if I notice anything that doesn't seem straightforward. Adding Oliver in case he wants to look it over since he implemented SeriazlizedScriptValue for JSC and is familiar with JSC.
Oliver Hunt
Comment 3 2011-10-16 11:13:41 PDT
Comment on attachment 111154 [details] Fix Looks sensible to me
WebKit Review Bot
Comment 4 2011-10-16 12:18:52 PDT
Comment on attachment 111154 [details] Fix Clearing flags on attachment: 111154 Committed r97576: <http://trac.webkit.org/changeset/97576>
WebKit Review Bot
Comment 5 2011-10-16 12:18:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.