Bug 76761

Created attachment 123421 [details] Patch

Comment on attachment 123421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123421&action=review I think it can be improved a bit more, r- for now. > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:66 > + // create table logins In general: Make comments look like sentences by starting with a capital letter and ending with a period. > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:104 > + // prepare the statments. statements. > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:105 > + Why empty line? > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:144 > + m_updateStatement =0; = 0 > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:254 > + Why empty line? > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:255 > + return credential; Why do we need a temp var here? > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:288 > + return false; This pattern is repeated a lot. Can you come up with macro(s)? If done correctly it will be much shorter and you don't need braces (go into macro).

Created attachment 124484 [details] Patch

Comment on attachment 124484 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=124484&action=review it loosk good, r+ Please re-upload with the suggestions addressed if you think they are convenient, and add "Reviewed by Antonio Gomes" to the new patch/changelog. No need to another review round, only cq+ needed. > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:70 > + // Create table logins I would drop this comment. it looks unneeded given the line below it. Also lacks a "." at the end :-) > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:74 > + // Create index for table logins ditto > Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:77 > + } else { // Initiate CredentialStorage . in the end

Created attachment 124493 [details] patch for cq after Antonio's review, also thanks Rob.

Comment on attachment 124493 [details] patch for cq after Antonio's review, also thanks Rob. Rejecting attachment 124493 [details] from commit-queue. jonathan.dong@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Created attachment 124494 [details] patch for cq re-attach the patch as wrongly set the commit-queue flag for the last patch. :(

Comment on attachment 124494 [details] patch for cq Use cq

Comment on attachment 124494 [details] patch for cq Clearing flags on attachment: 124494 Committed r106234: <http://trac.webkit.org/changeset/106234>

All reviewed patches have been landed. Closing bug.