Bug 80248

Summary: Geolocation should use a ScriptExecutionContext as its context object
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2012-03-05 00:31:10 PST
Geolocation should use a ScriptExecutionContext as its context object
Attachments
Patch (14.17 KB, patch)
2012-03-05 00:47 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.93 KB, patch)
2012-03-05 09:41 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-03-05 00:47:50 PST
Created attachment 130068 [details] Patch
Build Bot
Comment 2 2012-03-05 02:23:29 PST
Comment on attachment 130068 [details] Patch Attachment 130068 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11803899
Adam Barth
Comment 3 2012-03-05 09:41:11 PST
Created attachment 130155 [details] Patch for landing
Adam Barth
Comment 4 2012-03-05 10:18:03 PST
Committed r109761: <http://trac.webkit.org/changeset/109761>
Csaba Osztrogonác
Comment 5 2012-03-05 22:38:57 PST
Reopen, because it broke the --minimal build: /usr/bin/gold: /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/release/libWebCore.a(NavigatorGeolocation.o): in function WebCore::NavigatorGeolocation::geolocation() const:NavigatorGeolocation.cpp(.text._ZNK7WebCore20NavigatorGeolocation11geolocationEv+0x57): error: undefined reference to 'WebCore::Geolocation::create(WebCore::ScriptExecutionContext*)' c
Eric Seidel (no email)
Comment 6 2012-03-05 22:42:34 PST
We should consider adding a --minimal EWS bot to prevent such breakages.
Adam Barth
Comment 7 2012-03-05 23:25:35 PST
Thanks. Will fix in a moment when my working copy is free.
Adam Barth
Comment 8 2012-03-05 23:54:50 PST
Fix in https://bugs.webkit.org/show_bug.cgi?id=80390
Adam Barth
Comment 9 2012-03-23 17:25:53 PDT
This is fixed.
Note You need to log in before you can comment on or make changes to this bug.