Bug 80266

Summary: [Texmap][EFL] Implementation of AcceleratedCompositingContext for EFL port
Product: WebKit Reporter: Hyowon Kim <hw1008.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, igor.oliveira, lucas.de.marchi, noam, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 79766    
Attachments:
Description Flags
patch
none
modified patch
none
fix a style error none

Hyowon Kim
Reported 2012-03-05 04:41:18 PST
This patch adds EFL's implementation of AcceleratedCompositingContext to WebCoreSupport. Like GTK port, its instance will be created in WebView's private(Ewk_View_Private_Data). I'll upload anothor patch to do it soon.
Attachments
patch (7.63 KB, patch)
2012-03-05 04:46 PST, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
modified patch (7.64 KB, patch)
2012-03-08 00:02 PST, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
fix a style error (7.65 KB, patch)
2012-03-08 00:19 PST, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hyowon Kim
Comment 1 2012-03-05 04:46:04 PST
Created attachment 130095 [details] patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-03-05 05:52:56 PST
Comment on attachment 130095 [details] patch Don't you need to add the cpp file to Source/WebKit/PlatformEfl.cmake?
Noam Rosenthal
Comment 3 2012-03-05 07:12:26 PST
Comment on attachment 130095 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=130095&action=review Will review once the issue with the build files is resolved. > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContext.h:47 > + virtual void syncLayersNow(); > + > + virtual void renderLayers(); > + > + virtual void attachRootGraphicsLayer(GraphicsLayer* rootLayer); > + Do you really need all these line breaks?
Gyuyoung Kim
Comment 4 2012-03-05 20:35:13 PST
Comment on attachment 130095 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=130095&action=review > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContext.h:55 > + Evas_Object* m_webView; In order to be more compliant with EFL port coding style, you need to change m_webView with m_view.
Hyowon Kim
Comment 5 2012-03-08 00:02:52 PST
Created attachment 130784 [details] modified patch I think this patch can not add new AcceleratedCompositingContext.cpp file to cmakefile now, because anothor new file for PageClientEfl is needed. I'll try it in another patch.
Hyowon Kim
Comment 6 2012-03-08 00:05:47 PST
(In reply to comment #3) > (From update of attachment 130095 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130095&action=review > Will review once the issue with the build files is resolved. > > Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContext.h:47 > > + virtual void syncLayersNow(); > > + > > + virtual void renderLayers(); > > + > > + virtual void attachRootGraphicsLayer(GraphicsLayer* rootLayer); > > + > Do you really need all these line breaks? I've removed unnecessary new lines. I always appreciate your prompt review :D
WebKit Review Bot
Comment 7 2012-03-08 00:05:56 PST
Attachment 130784 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/efl/WebCoreSupport/AcceleratedCompositingContextEfl.h:20: #ifndef header guard has wrong style, please use: AcceleratedCompositingContextEfl_h [build/header_guard] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Hyowon Kim
Comment 8 2012-03-08 00:19:04 PST
Created attachment 130787 [details] fix a style error fixed a style error.
Hyowon Kim
Comment 9 2012-03-08 00:25:13 PST
(In reply to comment #2) > (From update of attachment 130095 [details]) > Don't you need to add the cpp file to Source/WebKit/PlatformEfl.cmake? Thanks for your interest. As mentioned above, I'll upload another patch to add new files to the list in cmakefile. If you don't mind, I'll add you to CC list in it.
Igor Trindade Oliveira
Comment 10 2012-03-08 07:08:59 PST
Have one question, EFL port will use texmap accelerated compositing or a evas based graphics layer for final production? (In reply to comment #9) > (In reply to comment #2) > > (From update of attachment 130095 [details] [details]) > > Don't you need to add the cpp file to Source/WebKit/PlatformEfl.cmake? > > Thanks for your interest. > As mentioned above, I'll upload another patch to add new files to the list in cmakefile. > If you don't mind, I'll add you to CC list in it.
WebKit Review Bot
Comment 11 2012-03-08 23:34:03 PST
Comment on attachment 130787 [details] fix a style error Clearing flags on attachment: 130787 Committed r110270: <http://trac.webkit.org/changeset/110270>
WebKit Review Bot
Comment 12 2012-03-08 23:34:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.