Bug 84093

Summary:

Add support for MessagePortArray type to JSC

Product:

WebKit

Reporter:

Greg Billock <gbillock>

Component:

WebCore JavaScript

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cdumez, haraken, japhet, ossy, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

86868

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-
Diff for Tools/Scripts/run-bindings-tests --reset-results	none
stdout output for Tools/Scripts/run-bindings-tests --reset-results	none
Patch for landing	none

Greg Billock

Reported 2012-04-16 16:11:36 PDT

See https://bugs.webkit.org/show_bug.cgi?id=83943 for V8 implementation.

Attachments
Patch (4.02 KB, patch) 2012-05-21 05:35 PDT, Chris Dumez	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
Diff for Tools/Scripts/run-bindings-tests --reset-results (5.76 KB, patch) 2012-05-21 05:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
stdout output for Tools/Scripts/run-bindings-tests --reset-results (2.99 KB, text/plain) 2012-05-21 05:37 PDT, Chris Dumez	no flags	Details
Patch for landing (10.60 KB, patch) 2012-05-21 09:20 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2012-05-20 22:52:09 PDT

This blocks WebIntents support for EFL port since the code added in r117384 (Web Intents Delivery) does not compile without this generator fix and there is no way to disable the Web Intents Delivery code at compile time.

Chris Dumez

Comment 2 2012-05-21 02:45:42 PDT

A similar fix to the one made to the V8 engine in Bug 81127 is also needed for the new Web Intents Delivery code to compile.

Chris Dumez

Comment 3 2012-05-21 05:35:57 PDT

Created attachment 143009 [details] Patch

Chris Dumez

Comment 4 2012-05-21 05:36:55 PDT

Created attachment 143010 [details] Diff for Tools/Scripts/run-bindings-tests --reset-results

Chris Dumez

Comment 5 2012-05-21 05:37:27 PDT

Created attachment 143011 [details] stdout output for Tools/Scripts/run-bindings-tests --reset-results

Chris Dumez

Comment 6 2012-05-21 05:49:33 PDT

Note that I had to make the following fix as well in order for the new Web Intents Delivery code to compile: - return "SerializedScriptValue::create(exec, $value)"; + return "SerializedScriptValue::create(exec, $value, 0, 0)"; This is because this function does not exist anymore: static PassRefPtr<SerializedScriptValue> create(JSC::ExecState*, JSC::JSValue, SerializationErrorMode = Throwing); It has been changed a while ago to: static PassRefPtr<SerializedScriptValue> create(JSC::ExecState*, JSC::JSValue, MessagePortArray*, ArrayBufferArray*, SerializationErrorMode = Throwing); I believe Bug 70186 added the MessagePortArray* argument. I probably should file a second bug for this one line fix? Just say the word and I'll do that.

Early Warning System Bot

Comment 7 2012-05-21 06:03:55 PDT

Comment on attachment 143009 [details] Patch Attachment 143009 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12747030

Csaba Osztrogonác

Comment 8 2012-05-21 06:06:46 PDT

(In reply to comment #7) > (From update of attachment 143009 [details]) > Attachment 143009 [details] did not pass qt-wk2-ews (qt): > Output: http://queues.webkit.org/results/12747030 Sorry, it was false positive alarm.

Chris Dumez

Comment 9 2012-05-21 06:08:04 PDT

Comment on attachment 143009 [details] Patch Restoring cq? flag since the ews warning was a false positive.

Early Warning System Bot

Comment 10 2012-05-21 06:08:20 PDT

Comment on attachment 143009 [details] Patch Attachment 143009 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12738416

Adam Barth

Comment 11 2012-05-21 09:02:59 PDT

Comment on attachment 143009 [details] Patch Ok. Please run-bindings-tests with --reset-results before landing so that the updated results are committed with your change.

Chris Dumez

Comment 12 2012-05-21 09:20:21 PDT

Created attachment 143045 [details] Patch for landing Include result from "Tools/Scripts/run-bindings-tests --reset-results" in the patch and update the Changelog accordingly.

WebKit Review Bot

Comment 13 2012-05-21 09:42:39 PDT

Comment on attachment 143045 [details] Patch for landing Clearing flags on attachment: 143045 Committed r117795: <http://trac.webkit.org/changeset/117795>

WebKit Review Bot

Comment 14 2012-05-21 09:42:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.