Bug 84400

Summary: setPageScaleFactor should setScrollPosition if scale is unchanged
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, dglazkov, eric, fsamuel, kenneth, peter, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ec2-cr-linux-04
none
Patch none

Alexandre Elias
Reported 2012-04-19 16:23:03 PDT
setPageScaleFactor should setScrollPosition if scale is unchanged
Attachments
Patch (2.42 KB, patch)
2012-04-19 16:29 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Patch (4.93 KB, patch)
2012-04-20 16:50 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-04 (6.23 MB, application/zip)
2012-04-20 19:00 PDT, WebKit Review Bot 		no flags
Details
Patch (4.87 KB, patch)
2012-04-20 20:03 PDT, Alexandre Elias 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexandre Elias
Comment 1 2012-04-19 16:29:43 PDT
Created attachment 138001 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-04-19 16:47:03 PDT
Comment on attachment 138001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138001&action=review Looks good, but a better explanation for the lack of tests is needed > Source/WebCore/ChangeLog:14 > + No new tests. Why?
Alexandre Elias
Comment 3 2012-04-20 16:50:37 PDT
Created attachment 138198 [details] Patch
Alexandre Elias
Comment 4 2012-04-20 16:51:25 PDT
OK, I added a layout test case.
WebKit Review Bot
Comment 5 2012-04-20 19:00:46 PDT
Comment on attachment 138198 [details] Patch Attachment 138198 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12482328 New failing tests: fast/events/scale-and-scroll-body.html
WebKit Review Bot
Comment 6 2012-04-20 19:00:52 PDT
Created attachment 138213 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Alexandre Elias
Comment 7 2012-04-20 20:03:30 PDT
Created attachment 138218 [details] Patch
Adam Barth
Comment 8 2012-05-09 16:24:08 PDT
Comment on attachment 138218 [details] Patch Based on kenneth's comment below and the new test, it looks like this is ready to go. Thanks.
WebKit Review Bot
Comment 9 2012-05-09 16:43:17 PDT
Comment on attachment 138218 [details] Patch Clearing flags on attachment: 138218 Committed r116574: <http://trac.webkit.org/changeset/116574>
WebKit Review Bot
Comment 10 2012-05-09 16:43:34 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 11 2012-05-09 16:46:30 PDT
Do all ports have this bug and it just hasn't been noticed before?
Note You need to log in before you can comment on or make changes to this bug.