Bug 88266

Summary: Adding a flag to show fullscreen media controls in chromium
Product: WebKit Reporter: Min Qin <qinmin>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing none

Min Qin
Reported 2012-06-04 16:32:51 PDT
Adding a flag to show fullscreen media controls in chromium
Attachments
Patch (6.03 KB, patch)
2012-06-04 16:40 PDT, Min Qin 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.71 KB, patch)
2012-06-11 01:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2012-06-04 16:40:38 PDT
Created attachment 145653 [details] Patch
Adam Barth
Comment 2 2012-06-11 00:36:40 PDT
Comment on attachment 145653 [details] Patch Thanks!
WebKit Review Bot
Comment 3 2012-06-11 00:42:47 PDT
Comment on attachment 145653 [details] Patch Rejecting attachment 145653 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing file Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp patching file Source/WebCore/html/shadow/MediaControlRootElementChromium.h patching file Source/WebKit/chromium/features.gypi Hunk #1 FAILED at 146. Hunk #2 FAILED at 155. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/features.gypi.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12942166
Adam Barth
Comment 4 2012-06-11 01:11:57 PDT
Created attachment 146805 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-06-11 02:26:46 PDT
Comment on attachment 146805 [details] Patch for landing Clearing flags on attachment: 146805 Committed r119966: <http://trac.webkit.org/changeset/119966>
WebKit Review Bot
Comment 6 2012-06-11 02:27:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.