Bug 88533

Summary: [Chromium] features.gypi should have the correct definitions for Android
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88564, 88636, 88637    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Peter Beverloo
Reported 2012-06-07 06:58:53 PDT
[Chromium] features.gypi should have the correct definitions for Android
Attachments
Patch (4.57 KB, patch)
2012-06-07 07:06 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-06-07 07:06:51 PDT
Created attachment 146282 [details] Patch
Peter Beverloo
Comment 2 2012-06-07 08:00:58 PDT
Comment on attachment 146282 [details] Patch Confirmed that this doesn't break the Android build. It's a no-op for other platforms.
WebKit Review Bot
Comment 3 2012-06-07 11:04:26 PDT
Comment on attachment 146282 [details] Patch Rejecting attachment 146282 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: WebCore::EUpdateLayout) const': Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1358: error: enumeration value 'CSSPropertyWebkitOverflowScrolling' not handled in switch CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSFontFace.o CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSFontFaceRule.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/css/CSSComputedStyleDeclaration.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/12923059
Peter Beverloo
Comment 4 2012-06-07 11:50:11 PDT
Comment on attachment 146282 [details] Patch Fixed that issue in r119743.
WebKit Review Bot
Comment 5 2012-06-07 13:08:21 PDT
Comment on attachment 146282 [details] Patch Clearing flags on attachment: 146282 Committed r119749: <http://trac.webkit.org/changeset/119749>
WebKit Review Bot
Comment 6 2012-06-07 13:08:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.