Bug 88630

Created attachment 146505 [details] Patch

Comment on attachment 146505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146505&action=review > Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h:30 > Well IIRC GraphicsSurface is just used right now by Qt in WK2. These changes should be in other patch. > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:363 > +#endif Explain better in changelog why you are using AnimationController instead of TextureMapper.

Comment on attachment 146505 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146505&action=review WebKit tends to avoid to land multiple patches at once. Because, it can land insufficient reviewed patch. So, I also think you need to divide this patch. > Source/WebCore/platform/graphics/GraphicsLayer.h:82 > +#elif PLATFORM(EFL) Don't you need to use below macro ? QT and GTK have used this. #if USE(TEXTURE_MAPPER) > Source/WebCore/platform/graphics/OpenGLShims.cpp:20 > +#if ENABLE(WEBGL) || defined(QT_OPENGL_SHIMS) || (PLATFORM(EFL) && USE(ACCELERATED_COMPOSITING)) I don't understand why you need to add EFL and ACCELERATED_COMPOSITING macro. I think you can use this file by enabling WEBGL. Isn't it ? >> Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h:30 >> > > Well IIRC GraphicsSurface is just used right now by Qt in WK2. These changes should be in other patch. As Igor said, you need to get review from Qt and WK2 reviewers. And also, it looks you need to write patch description more details. Because, this is common file for some ports. > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:88 > +#elif defined(XP_UNIX) && !PLATFORM(EFL) As Igor said, you have to explain why EFL port doesn't want to enable this. > Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:40 > +bool PageClientEfl::createEvasObjectForAcceleratedCompositing(Evas_Native_Surface* nativeSurface, const WebCore::IntRect& rect) In EFL port, we have used IntRect directly by including "IntRect.h".

Comment on attachment 146505 [details] Patch Cleared review? from attachment 146505 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach new patch to this bug or new bug again.

Created attachment 170289 [details] new patch for AcceleratedCompositingContextEfl I tried to cram too many items into this patch. Sorry. Most problems seem to be solved. So I've changed the bug title and attached a new patch for only AcceleratedCompositingContextEfl.

Comment on attachment 170289 [details] new patch for AcceleratedCompositingContextEfl Clearing flags on attachment: 170289 Committed r132300: <http://trac.webkit.org/changeset/132300>

All reviewed patches have been landed. Closing bug.