Bug 89833

Summary: Change the type of the second argument of FrameSelection::revealSelection to use RevealExtentOption
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: HTML EditingAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 88999    
Bug Blocks:    
Attachments:
Description Flags
Work in progress
none
Patch
none
Patch for landing none

WebKit Review Bot
Reported 2012-06-24 12:08:43 PDT
Change the type of the second argument of FrameSelection::revealSelection to use RevealExtentOption Requested by abarth_ on #webkit.
Attachments
Work in progress (4.91 KB, patch)
2012-06-24 12:18 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (5.81 KB, patch)
2012-06-24 12:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.81 KB, patch)
2012-06-24 15:28 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-06-24 12:09:59 PDT
As requested by rniwa in Bug 88999.
Adam Barth
Comment 2 2012-06-24 12:18:24 PDT
Created attachment 149200 [details] Work in progress
Adam Barth
Comment 3 2012-06-24 12:58:46 PDT
Created attachment 149202 [details] Patch
Adam Barth
Comment 4 2012-06-24 15:28:11 PDT
Created attachment 149205 [details] Patch for landing
Adam Barth
Comment 5 2012-06-24 15:28:29 PDT
Comment on attachment 149205 [details] Patch for landing Let's give the EWS a chance to tell me what I've broken.
WebKit Review Bot
Comment 6 2012-06-24 17:29:21 PDT
Comment on attachment 149205 [details] Patch for landing Clearing flags on attachment: 149205 Committed r121125: <http://trac.webkit.org/changeset/121125>
WebKit Review Bot
Comment 7 2012-06-24 17:29:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.