Bug 90920

Summary: [Chromium] Merge final nits to DumpRenderTree.gyp for Android
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, peter, tony, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90947, 92858, 92865    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Adam Barth
Reported 2012-07-10 16:57:21 PDT
[Chromium] Merge final nits to DumpRenderTree.gyp for Android
Attachments
Patch (1.93 KB, patch)
2012-07-10 16:58 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.59 KB, patch)
2012-07-10 22:25 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.43 KB, patch)
2012-08-02 08:37 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-07-10 16:58:23 PDT
Created attachment 151554 [details] Patch
Peter Beverloo
Comment 2 2012-07-10 16:59:12 PDT
LGTM
Peter Beverloo
Comment 3 2012-07-10 17:00:49 PDT
Comment on attachment 151554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151554&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:256 > + ['exclude', 'WebUserMediaClientMock\\.cpp'], nit: This whole file is guarded with ENABLE(MEDIA_STREAM), which isn't the case for Android. Could probably revert this downstream instead.
Adam Barth
Comment 4 2012-07-10 20:14:19 PDT
OK. Will do.
Adam Barth
Comment 5 2012-07-10 22:25:09 PDT
Created attachment 151598 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-07-10 23:19:28 PDT
Comment on attachment 151598 [details] Patch for landing Clearing flags on attachment: 151598 Committed r122301: <http://trac.webkit.org/changeset/122301>
WebKit Review Bot
Comment 7 2012-07-10 23:19:33 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2012-07-11 00:23:17 PDT
Re-opened since this is blocked by 90947
Peter Beverloo
Comment 9 2012-07-11 07:47:57 PDT
This relies on some not-yet-upstreamed Chromium code. I've e-mailed the author with some questions, so we can hopefully get this in tomorrow. For reference: https://gerrit-int.chromium.org/#change,19828
Adam Barth
Comment 10 2012-07-29 02:47:29 PDT
> This relies on some not-yet-upstreamed Chromium code. I've e-mailed the author with some questions, so we can hopefully get this in tomorrow. @Peter: Are we ready to land this patch yet?
Peter Beverloo
Comment 11 2012-07-29 05:03:41 PDT
Per http://crrev.com/148790 the sdk_build variable will be pushed to gyp, but I'm not sure if it's propagated properly yet. I had to revert the revision last week as it unintentionally switched the WebKit cr-android builder to using ninja. That has been fixed in the re-land, so we can go forth, roll WebKit Chromium DEPS and, if needed, fix propagation of the variable (though that'd be easy). Tomorrow -finally- is reasonable. IIRC a similar one-line diff exists for TestWebKitAPI and webkit_unit_test.
Adam Barth
Comment 12 2012-07-29 10:30:06 PDT
Ok. Thanks. There isn't really a rush. We'll just need to get this off our plate eventually. After https://gerrit-int.chromium.org/22653 lands, this one-line change will be the last thing keeping us from having DumpRenderTree fully unforked.
Peter Beverloo
Comment 13 2012-07-31 08:24:22 PDT
Once a new Chromium DEPS roll happens in WebKit (only blocked on getting a Chromium LKGR > 149181), it's fine to land this. Should be today :-).
Peter Beverloo
Comment 14 2012-08-01 03:11:25 PDT
Comment on attachment 151598 [details] Patch for landing Boldly setting cq+.
WebKit Review Bot
Comment 15 2012-08-01 04:51:59 PDT
Comment on attachment 151598 [details] Patch for landing Clearing flags on attachment: 151598 Committed r124325: <http://trac.webkit.org/changeset/124325>
WebKit Review Bot
Comment 16 2012-08-01 04:52:03 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 17 2012-08-01 05:10:39 PDT
Re-opened since this is blocked by 92865
Peter Beverloo
Comment 18 2012-08-02 07:00:32 PDT
Comment on attachment 151598 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=151598&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:454 > + '--ant-compile=<(sdk_build)', "--sdk-build=<(sdk_build)", then LGTM again.. Thanks!
Adam Barth
Comment 19 2012-08-02 08:37:07 PDT
Created attachment 156095 [details] Patch for landing
WebKit Review Bot
Comment 20 2012-08-02 09:30:59 PDT
Comment on attachment 156095 [details] Patch for landing Clearing flags on attachment: 156095 Committed r124467: <http://trac.webkit.org/changeset/124467>
WebKit Review Bot
Comment 21 2012-08-02 09:31:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.