Bug 94125

Summary: Web Inspector: enable instrumentation of platform code
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, gyuyoung.kim, joepeck, keishi, loislo, pfeldman, pmuellr, rakuco, rik, senorblanco, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 90277    
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Andrey Kosyakov
Reported 2012-08-15 10:54:35 PDT
Currently, we use InspectorInstrumentation as the interface that is used by inspector to instrument. This can't be used to instrument code under WebCore/platform, though, as this is deemed to be a layering violation. So let's add a lower-level instrumentation interface and implement its client within the inspector.
Attachments
Patch (27.85 KB, patch)
2012-08-15 11:03 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (32.30 KB, patch)
2012-08-16 02:24 PDT, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (36.58 KB, patch)
2012-08-16 04:50 PDT, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-08-15 11:03:48 PDT
Created attachment 158595 [details] Patch
Nat Duca
Comment 2 2012-08-15 11:30:07 PDT
Comment on attachment 158595 [details] Patch This looks great.
Build Bot
Comment 3 2012-08-15 12:15:13 PDT
Comment on attachment 158595 [details] Patch Attachment 158595 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13509282
Andrey Kosyakov
Comment 4 2012-08-16 02:24:55 PDT
Created attachment 158756 [details] Patch
Pavel Feldman
Comment 5 2012-08-16 03:34:21 PDT
Comment on attachment 158756 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158756&action=review Minor nits, otherwise looks good. > Source/WebCore/inspector/InspectorTimelineAgent.cpp:-491 > - InspectorInstrumentation::setTimelineAgentForOrphanEvents(0); You should remove InspectorInstrumentation::setTimelineAgentForOrphanEvents, InspectorInstrumentation::threadSpecificTimelineAgentForOrphanEvents, etc. as well > Source/WebCore/inspector/InspectorTimelineAgent.cpp:556 > + m_platformInstrumentationClientSet = m_recordStack.size(); m_platformInstrumentationClientInstalledAtStackDepth > Source/WebCore/platform/PlatformInstrumentation.h:46 > + virtual void willDecodeImage(const WTF::String& imageType) = 0; Here and below drop WTF:: > Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:265 > + if (frame.status() != ImageFrame::FrameComplete) { You did not remove TRACE_EVENT macro / include.
Andrey Kosyakov
Comment 6 2012-08-16 04:50:32 PDT
Created attachment 158775 [details] Patch
Andrey Kosyakov
Comment 7 2012-08-16 05:07:00 PDT
Committed r125769: <http://trac.webkit.org/changeset/125769>
Note You need to log in before you can comment on or make changes to this bug.