Bug 9577

Summary:

Fallback for <object> not rendered if plug-in unavailable

Product:

WebKit

Reporter:

Nicholas Shanks <nickshanks>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, mitz, webkit

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://web.nickshanks.com/typography/sans-serif

Attachments:

Description	Flags
First attempt	none
Improved patch	none
improved patch	none

Nicholas Shanks

Reported 2006-06-25 11:25:02 PDT

When plug-ins are disabled, <object> elements don't instead display their fallback HTML code. See above page for an example

Attachments
First attempt (12.57 KB, patch) 2006-07-01 15:13 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Improved patch (12.02 KB, patch) 2006-07-02 13:09 PDT, Rob Buis	no flags	Details Formatted Diff Diff
improved patch (12.28 KB, patch) 2006-07-03 06:45 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2006-06-25 13:25:05 PDT

Duplicate of bug 3742?

Rob Buis

Comment 2 2006-07-01 15:13:03 PDT

Created attachment 9129 [details] First attempt The patch fixes the bug for me. I can do testcase(s) if the code gets okayed in the first place :-) Cheers, Rob.

Rob Buis

Comment 3 2006-07-02 13:09:22 PDT

Created attachment 9151 [details] Improved patch This patch fixes a problem with the one before, m_hasFallbackContent has to be determined if plugins are disabled. Cheers, Rob.

Rob Buis

Comment 4 2006-07-03 06:45:11 PDT

Created attachment 9166 [details] improved patch I am not sure whether the previous patch worked 100%, anyway this one is tested ok against the testcase and has no regressions. Also it fixes bug 7536, since that one is closely related. I checked the testcases in FF and IE6 and the patch matches that behaviour. Let me know if I can start doing the testcases, I think the ones from bug 7536 and this one are an ok start? Cheers, Rob.

Darin Adler

Comment 5 2006-07-03 18:26:54 PDT

Comment on attachment 9166 [details] improved patch Does Acid2 still pass?

Rob Buis

Comment 6 2006-07-04 00:55:51 PDT

Hi Darin, (In reply to comment #5) > (From update of attachment 9166 [details] [edit]) > Does Acid2 still pass? In my run-webkit-tests runs acid2 works fine. I wonder btw if it takes into account plugins enabled/disabled? I tried both but didnt spot a difference. Cheers, Rob.

Maciej Stachowiak

Comment 7 2006-07-04 01:15:11 PDT

Comment on attachment 9166 [details] improved patch r=me

Rob Buis

Comment 8 2006-07-04 03:21:44 PDT

Hi Maciej, Darin, (In reply to comment #7) > (From update of attachment 9166 [details] [edit]) > r=me Nice! Any advice on the best road to finish the patch? Is it ok that it may fix two seperate bugs? Does it need a testcase for both, a combined testcase or are there existing testcases that test the two bugs? Cheers, Rob.

Darin Adler

Comment 9 2006-07-04 10:50:48 PDT

(In reply to comment #8) > Any advice on the best road to finish the patch? Is it ok > that it may fix two seperate bugs? Does it need a testcase for > both, a combined testcase or are there existing testcases that test > the two bugs? The more test cases the better. Ideally the test cases independently demonstrate each thing you noticed that was broken in the old code, anything you realize you might have gotten wrong if you weren't such a careful programmer, and anything you're concerned that later hackers might break in the new code you made. It doesn't really matter how many separate bug reports there are. What's more important is what observable problems there are -- we want to test each of these in case they get screwed up later. I don't know the status here about which test cases already exist -- you could make a list of what needs to be tested and then check yourself.

Darin Adler

Comment 10 2006-07-08 09:36:15 PDT

Comment on attachment 9166 [details] improved patch Clearing the review flag so this doesn't appear in our patches to be commited list. Please set the review flag again when you have a patch with tests that's ready to review and land.

mitz

Comment 11 2007-09-20 10:39:15 PDT

Is the bug still present in TOT?

David Kilzer (:ddkilzer)

Comment 12 2007-09-20 10:45:15 PDT